Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip prod(deps): bump pyright from 1.1.335 to 1.1.336 #1796

Merged
merged 9 commits into from
Nov 23, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 16, 2023

Bumps pyright from 1.1.335 to 1.1.336.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [pyright](https://github.com/RobertCraigie/pyright-python) from 1.1.335 to 1.1.336.
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.335...v1.1.336)

---
updated-dependencies:
- dependency-name: pyright
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fb162bb) 88.90% compared to head (97d4082) 89.21%.
Report is 17 commits behind head on main.

Files Patch % Lines
xdsl/dialects/builtin.py 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
+ Coverage   88.90%   89.21%   +0.31%     
==========================================
  Files         260      262       +2     
  Lines       32050    32352     +302     
  Branches     4725     4781      +56     
==========================================
+ Hits        28495    28864     +369     
+ Misses       2862     2795      -67     
  Partials      693      693              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@compor
Copy link
Collaborator

compor commented Nov 16, 2023

Having a look

@compor
Copy link
Collaborator

compor commented Nov 16, 2023

I just simplified the errors in builtin.py, but I couldn't find a combination that works (restricts the type properly); it seems that typing.Annotated used in ParameterDef type alias is at the bottom of this.

PS: Feel free to revert any commits of mine

@compor
Copy link
Collaborator

compor commented Nov 17, 2023

Look like a regression microsoft/pyright#6475 (at least the type error in builtin.py)

@PapyChacal
Copy link
Collaborator

And I think the rest is explained by microsoft/pyright#6452
I would just wait for 1.1.337? it looks like we can expect it in ~2 days.

@PapyChacal
Copy link
Collaborator

Pyright 1.1.337 is released, and advertising fixes for those, but is not yet published on PyPi. I'm watching it and will check if this version solves our problems!

@PapyChacal
Copy link
Collaborator

Pyright 1.1.337 solves the builtin issue, but not the core one about irdl_definition of ParameterizedAttribute 🙁
This one can be solved on our side! @math-fehr had an idea

@math-fehr
Copy link
Collaborator

I think I found an easier fix. It seems that pyright got confused with Self here.

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 23, 2023

A newer version of pyright exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@tobiasgrosser tobiasgrosser merged commit e098240 into main Nov 23, 2023
10 checks passed
@tobiasgrosser tobiasgrosser deleted the dependabot/pip/pyright-1.1.336 branch November 23, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants